[PATCH] [ARM] Don't break alignment when combining base updates into load/stores.
Quentin Colombet
qcolombet at apple.com
Mon Dec 22 16:39:08 PST 2014
Hi Ahmed,
LGTM with one small nitpick.
Thanks,
-Quentin
================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:8986
@@ +8985,3 @@
+ // Intrinsics are assumed to be aligned, so no need to handle them.
+ if (LSBaseSDNode *LSN = dyn_cast<LSBaseSDNode>(N)) {
+ unsigned Alignment = LSN->getAlignment();
----------------
Looking just at the possible code path, one may wonder why we do not need to handle V(ST|LD)xDUP.
Add a comment saying that by construction those are assumed to be properly aligned, that is why we just need to test for regular load/store.
http://reviews.llvm.org/D6759
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list