[llvm] r224260 - [X86] Also pretty-print shuffle mask for INSERTPS rm variants.

Chandler Carruth chandlerc at google.com
Mon Dec 15 11:38:56 PST 2014


Add a quick test case? Usually easy to synthesize one with the intrinsic
tests...

On Mon, Dec 15, 2014 at 11:17 AM, Ahmed Bougacha <ahmed.bougacha at gmail.com>
wrote:
>
> Author: ab
> Date: Mon Dec 15 13:17:54 2014
> New Revision: 224260
>
> URL: http://llvm.org/viewvc/llvm-project?rev=224260&view=rev
> Log:
> [X86] Also pretty-print shuffle mask for INSERTPS rm variants.
>
> Modified:
>     llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp
>
> Modified: llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp?rev=224260&r1=224259&r2=224260&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp (original)
> +++ llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp Mon Dec 15
> 13:17:54 2014
> @@ -140,11 +140,15 @@ bool llvm::EmitAnyX86InstComments(const
>
>    case X86::INSERTPSrr:
>    case X86::VINSERTPSrr:
> +    Src2Name = getRegName(MI->getOperand(2).getReg());
> +    // FALL THROUGH.
> +  case X86::INSERTPSrm:
> +  case X86::VINSERTPSrm:
>      DestName = getRegName(MI->getOperand(0).getReg());
>      Src1Name = getRegName(MI->getOperand(1).getReg());
> -    Src2Name = getRegName(MI->getOperand(2).getReg());
> -    if(MI->getOperand(3).isImm())
> -      DecodeINSERTPSMask(MI->getOperand(3).getImm(), ShuffleMask);
> +    if(MI->getOperand(MI->getNumOperands()-1).isImm())
> +      DecodeINSERTPSMask(MI->getOperand(MI->getNumOperands()-1).getImm(),
> +                         ShuffleMask);
>      break;
>
>    case X86::MOVLHPSrr:
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141215/4dbaf1f3/attachment.html>


More information about the llvm-commits mailing list