<div dir="ltr">Add a quick test case? Usually easy to synthesize one with the intrinsic tests...</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 15, 2014 at 11:17 AM, Ahmed Bougacha <span dir="ltr"><<a href="mailto:ahmed.bougacha@gmail.com" target="_blank">ahmed.bougacha@gmail.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ab<br>
Date: Mon Dec 15 13:17:54 2014<br>
New Revision: 224260<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=224260&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=224260&view=rev</a><br>
Log:<br>
[X86] Also pretty-print shuffle mask for INSERTPS rm variants.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp?rev=224260&r1=224259&r2=224260&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp?rev=224260&r1=224259&r2=224260&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp Mon Dec 15 13:17:54 2014<br>
@@ -140,11 +140,15 @@ bool llvm::EmitAnyX86InstComments(const<br>
<br>
   case X86::INSERTPSrr:<br>
   case X86::VINSERTPSrr:<br>
+    Src2Name = getRegName(MI->getOperand(2).getReg());<br>
+    // FALL THROUGH.<br>
+  case X86::INSERTPSrm:<br>
+  case X86::VINSERTPSrm:<br>
     DestName = getRegName(MI->getOperand(0).getReg());<br>
     Src1Name = getRegName(MI->getOperand(1).getReg());<br>
-    Src2Name = getRegName(MI->getOperand(2).getReg());<br>
-    if(MI->getOperand(3).isImm())<br>
-      DecodeINSERTPSMask(MI->getOperand(3).getImm(), ShuffleMask);<br>
+    if(MI->getOperand(MI->getNumOperands()-1).isImm())<br>
+      DecodeINSERTPSMask(MI->getOperand(MI->getNumOperands()-1).getImm(),<br>
+                         ShuffleMask);<br>
     break;<br>
<br>
   case X86::MOVLHPSrr:<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>