[llvm] r224090 - Bitcode: Add missing "Remove in 4.0" comments

[Sean Silva]

This is just the marker for identifying things to remove. I think it dates
back to a time with a different policy.

On Fri, Dec 12, 2014 at 10:41 AM, Robinson, Paul <
Paul_Robinson at playstation.sony.com> wrote:
>
> Shouldn't that be "4.1"?  I thought 4.0 was still supposed to be able
> to read 3.x bitcode.
> --paulr
>
> > -----Original Message-----
> > From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> > bounces at cs.uiuc.edu] On Behalf Of Duncan P. N. Exon Smith
> > Sent: Thursday, December 11, 2014 6:12 PM
> > To: llvm-commits at cs.uiuc.edu
> > Subject: [llvm] r224090 - Bitcode: Add missing "Remove in 4.0" comments
> >
> > Author: dexonsmith
> > Date: Thu Dec 11 20:11:31 2014
> > New Revision: 224090
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=224090&view=rev
> > Log:
> > Bitcode: Add missing "Remove in 4.0" comments
> >
> > Modified:
> >     llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
> >
> > Modified: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
> > URL: http://llvm.org/viewvc/llvm-
> >
> project/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp?rev=224090&r1=2240
> > 89&r2=224090&view=diff
> >
> ==========================================================================
> > ====
> > --- llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp (original)
> > +++ llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp Thu Dec 11 20:11:31
> > 2014
> > @@ -1116,6 +1116,7 @@ std::error_code BitcodeReader::ParseMeta
> >        break;
> >      }
> >      case bitc::METADATA_OLD_FN_NODE: {
> > +      // FIXME: Remove in 4.0.
> >        // This is a LocalAsMetadata record, the only type of function-
> > local
> >        // metadata.
> >        if (Record.size() % 2 == 1)
> > @@ -1143,6 +1144,7 @@ std::error_code BitcodeReader::ParseMeta
> >        break;
> >      }
> >      case bitc::METADATA_OLD_NODE: {
> > +      // FIXME: Remove in 4.0.
> >        if (Record.size() % 2 == 1)
> >          return Error(BitcodeError::InvalidRecord);
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141212/6ce41330/attachment.html>