<div dir="ltr">This is just the marker for identifying things to remove. I think it dates back to a time with a different policy.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 12, 2014 at 10:41 AM, Robinson, Paul <span dir="ltr"><<a href="mailto:Paul_Robinson@playstation.sony.com" target="_blank">Paul_Robinson@playstation.sony.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Shouldn't that be "4.1"?  I thought 4.0 was still supposed to be able<br>
to read 3.x bitcode.<br>
--paulr<br>
<div class="HOEnZb"><div class="h5"><br>
> -----Original Message-----<br>
> From: <a href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a> [mailto:<a href="mailto:llvm-commits-">llvm-commits-</a><br>
> <a href="mailto:bounces@cs.uiuc.edu">bounces@cs.uiuc.edu</a>] On Behalf Of Duncan P. N. Exon Smith<br>
> Sent: Thursday, December 11, 2014 6:12 PM<br>
> To: <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> Subject: [llvm] r224090 - Bitcode: Add missing "Remove in 4.0" comments<br>
><br>
> Author: dexonsmith<br>
> Date: Thu Dec 11 20:11:31 2014<br>
> New Revision: 224090<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=224090&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=224090&view=rev</a><br>
> Log:<br>
> Bitcode: Add missing "Remove in 4.0" comments<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp<br>
><br>
> Modified: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
> project/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp?rev=224090&r1=2240<br>
> 89&r2=224090&view=diff<br>
> ==========================================================================<br>
> ====<br>
> --- llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp (original)<br>
> +++ llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp Thu Dec 11 20:11:31<br>
> 2014<br>
> @@ -1116,6 +1116,7 @@ std::error_code BitcodeReader::ParseMeta<br>
>        break;<br>
>      }<br>
>      case bitc::METADATA_OLD_FN_NODE: {<br>
> +      // FIXME: Remove in 4.0.<br>
>        // This is a LocalAsMetadata record, the only type of function-<br>
> local<br>
>        // metadata.<br>
>        if (Record.size() % 2 == 1)<br>
> @@ -1143,6 +1144,7 @@ std::error_code BitcodeReader::ParseMeta<br>
>        break;<br>
>      }<br>
>      case bitc::METADATA_OLD_NODE: {<br>
> +      // FIXME: Remove in 4.0.<br>
>        if (Record.size() % 2 == 1)<br>
>          return Error(BitcodeError::InvalidRecord);<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div></div>