[PATCH] [X86] Make EltsFromConsecutiveLoads code path work only on vectors it expects

Michael Kuperstein michael.m.kuperstein at intel.com
Tue Dec 9 12:13:30 PST 2014


Thanks for the review, Sanjay.

Right about the test-case, it was bugpoint-reduced, and I didn't clean it up enough, thanks for pointing it out. 
Will fix and put it in the right place.

Regarding vector loads of i8 / i16 - I believe that didn't work to begin with.
The existing code fires only when NumElems == 4, and creates a ResNode of type v2i64. So for the bitcast in the end to be valid, the element size must be 32 bit. Or did I miss something?

Regarding the PR - you're right, it looks like unneeded domain crossing. I'd rather resolve the crash first, though.

http://reviews.llvm.org/D6579






More information about the llvm-commits mailing list