[PATCH] Supported llvm.dbg.declare intrinsic in inline pass

Adrian Prantl aprantl at apple.com
Thu Dec 4 17:09:27 PST 2014


> On Dec 4, 2014, at 5:00 PM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> Happy to punt this one to someone who might be more familiar with the variable tracking stuff - I've not really looked at it very hard (yeah, this patch looks pretty obvious, but that just goes to show how little confidence I have in my understanding of these things)

Looks good to me. There are situations where dbg.declares currently cannot be lowered into dbg.values (array alloca’s would be an example), so this seems to be reasonable.

-- adrian

> 
> On Thu, Dec 4, 2014 at 3:39 PM, Robinson, Paul <Paul_Robinson at playstation.sony.com <mailto:Paul_Robinson at playstation.sony.com>> wrote:
> Thanks for correcting this oversight!  LGTM but dblaikie gets the final
> word, I think.
> --paulr
> 
> > -----Original Message-----
> > From: Amjad Aboud [mailto:amjad.aboud at intel.com <mailto:amjad.aboud at intel.com>]
> > Sent: Thursday, December 04, 2014 12:05 PM
> > To: amjad.aboud at intel.com <mailto:amjad.aboud at intel.com>; eugenis at google.com <mailto:eugenis at google.com>; Robinson, Paul
> > Cc: dblaikie at gmail.com <mailto:dblaikie at gmail.com>; llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
> > Subject: Re: [PATCH] Supported llvm.dbg.declare intrinsic in inline pass
> >
> > http://reviews.llvm.org/D6525 <http://reviews.llvm.org/D6525>
> >
> > Files:
> >   lib/Transforms/Utils/InlineFunction.cpp
> >   test/Transforms/Inline/inline_dbg_declare.ll
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141204/af230c4e/attachment.html>


More information about the llvm-commits mailing list