<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 4, 2014, at 5:00 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Happy to punt this one to someone who might be more familiar with the variable tracking stuff - I've not really looked at it very hard (yeah, this patch looks pretty obvious, but that just goes to show how little confidence I have in my understanding of these things)</div></div></blockquote><div><br class=""></div><div>Looks good to me. There are situations where dbg.declares currently cannot be lowered into dbg.values (array alloca’s would be an example), so this seems to be reasonable.</div><div><br class=""></div><div>-- adrian</div><div><br class=""></div><blockquote type="cite" class=""><div class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Dec 4, 2014 at 3:39 PM, Robinson, Paul <span dir="ltr" class=""><<a href="mailto:Paul_Robinson@playstation.sony.com" target="_blank" class="">Paul_Robinson@playstation.sony.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks for correcting this oversight! LGTM but dblaikie gets the final<br class="">
word, I think.<br class="">
--paulr<br class="">
<div class="HOEnZb"><div class="h5"><br class="">
> -----Original Message-----<br class="">
> From: Amjad Aboud [mailto:<a href="mailto:amjad.aboud@intel.com" class="">amjad.aboud@intel.com</a>]<br class="">
> Sent: Thursday, December 04, 2014 12:05 PM<br class="">
> To: <a href="mailto:amjad.aboud@intel.com" class="">amjad.aboud@intel.com</a>; <a href="mailto:eugenis@google.com" class="">eugenis@google.com</a>; Robinson, Paul<br class="">
> Cc: <a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>; <a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">
> Subject: Re: [PATCH] Supported llvm.dbg.declare intrinsic in inline pass<br class="">
><br class="">
> <a href="http://reviews.llvm.org/D6525" target="_blank" class="">http://reviews.llvm.org/D6525</a><br class="">
><br class="">
> Files:<br class="">
> lib/Transforms/Utils/InlineFunction.cpp<br class="">
> test/Transforms/Inline/inline_dbg_declare.ll<br class="">
</div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>