[PATCH] Prevent the creation of empty location list ranges.

Adrian Prantl aprantl at apple.com
Wed Dec 3 09:23:14 PST 2014


================
Comment at: test/DebugInfo/X86/block-capture.ll:9
@@ +8,3 @@
+; location list. Now that we do not generate such invalid (empty) entries anymore,
+; the varible doesn't appear at all.
+; XFAIL: *
----------------
friss wrote:
> dblaikie wrote:
> > Just because we don't generate any locations doesn't mean we should omit the variable entirely - maybe a comment explaining that the missing variable is a (rather severe) bug, even if it doesn't have any location (another, perhaps less severe, bug, most likely)
> I thought this was implicit due to the XFAIL, but I can make it even more visible.
I'll have a look at this and see how we can fix the test case.

================
Comment at: test/DebugInfo/X86/dbg-value-inlined-parameter.ll:34
@@ -33,2 +33,3 @@
 
+;FIXME: We shouldn't drop the sp parameter.
 ;CHECK: DW_TAG_formal_parameter
----------------
If we drop the DW_TAG_formal_parameter completely, the function signature doesn't match the subroutine type any more. I think the formal parameter should still be there, even if it has no location.

http://reviews.llvm.org/D6497






More information about the llvm-commits mailing list