[lld] r223073 - [Core] Remove function to not override RoundTripPasses.

[Rui Ueyama]

Could you elaborate a bit why you didn't just roll back r222983?

This patch partially rolled back r222983 and the code left behind doesn't
make sense to me. That's why I wanted to roll it back completely.

On Mon, Dec 1, 2014 at 1:41 PM, Shankar Easwaran <shankare at codeaurora.org>
wrote:

> I couldnt follow, the member variable, function and the constructor needs
> to be in separate files.
>
>
> On 12/1/2014 3:27 PM, Rui Ueyama wrote:
>
>> This seems like a hand-written roll back change for r222983. Before
>> r222983,
>> the round-trip tests were confined in one #ifndef NDEBUG. Now it scattered
>> across the file. Please roll r222983 back entirely to clean it up.
>>
>> On Mon, Dec 1, 2014 at 12:28 PM, Shankar Easwaran <
>> shankare at codeaurora.org>
>> wrote:
>>
>>  Author: shankare
>>> Date: Mon Dec  1 14:28:54 2014
>>> New Revision: 223073
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=223073&view=rev
>>> Log:
>>> [Core] Remove function to not override RoundTripPasses.
>>>
>>> RoundTripPasses should always be called in DEBUG mode if the environment
>>> variable "LLD_RUN_ROUNDTRIP_TEST" is set.
>>>
>>> Flavors should not be able to override this behavior.
>>>
>>> Modified:
>>>      lld/trunk/include/lld/Core/LinkingContext.h
>>>      lld/trunk/lib/Core/LinkingContext.cpp
>>>
>>> Modified: lld/trunk/include/lld/Core/LinkingContext.h
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/
>>> Core/LinkingContext.h?rev=223073&r1=223072&r2=223073&view=diff
>>>
>>> ============================================================
>>> ==================
>>> --- lld/trunk/include/lld/Core/LinkingContext.h (original)
>>> +++ lld/trunk/include/lld/Core/LinkingContext.h Mon Dec  1 14:28:54 2014
>>> @@ -319,10 +319,6 @@ public:
>>>     virtual uint64_t getNextOrdinalAndIncrement() const { return
>>> _nextOrdinal++; }
>>>
>>>   #ifndef NDEBUG
>>> -  void setRunRoundTripPass(bool roundTripPass) {
>>> -    _runRoundTripPasses = roundTripPass;
>>> -  }
>>> -
>>>     bool runRoundTripPass() const { return _runRoundTripPasses; }
>>>   #endif
>>>
>>>
>>> Modified: lld/trunk/lib/Core/LinkingContext.cpp
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/
>>> LinkingContext.cpp?rev=223073&r1=223072&r2=223073&view=diff
>>>
>>> ============================================================
>>> ==================
>>> --- lld/trunk/lib/Core/LinkingContext.cpp (original)
>>> +++ lld/trunk/lib/Core/LinkingContext.cpp Mon Dec  1 14:28:54 2014
>>> @@ -32,7 +32,7 @@ LinkingContext::LinkingContext()
>>>     llvm::Optional<std::string> env =
>>>         llvm::sys::Process::GetEnv("LLD_RUN_ROUNDTRIP_TEST");
>>>     if (env.hasValue() && !env.getValue().empty())
>>> -    setRunRoundTripPass(true);
>>> +    _runRoundTripPasses = true;
>>>   }
>>>   #else
>>>   LinkingContext::LinkingContext()
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>>
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by the Linux Foundation
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141201/c4784d2f/attachment.html>