<div dir="ltr">Could you elaborate a bit why you didn't just roll back r222983?<div><br></div><div>This patch partially rolled back r222983 and the code left behind doesn't make sense to me. That's why I wanted to roll it back completely.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 1, 2014 at 1:41 PM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I couldnt follow, the member variable, function and the constructor needs to be in separate files.<div class="HOEnZb"><div class="h5"><br>
<br>
On 12/1/2014 3:27 PM, Rui Ueyama wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This seems like a hand-written roll back change for r222983. Before r222983,<br>
the round-trip tests were confined in one #ifndef NDEBUG. Now it scattered<br>
across the file. Please roll r222983 back entirely to clean it up.<br>
<br>
On Mon, Dec 1, 2014 at 12:28 PM, Shankar Easwaran <<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>><br>
wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: shankare<br>
Date: Mon Dec  1 14:28:54 2014<br>
New Revision: 223073<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=223073&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=223073&view=rev</a><br>
Log:<br>
[Core] Remove function to not override RoundTripPasses.<br>
<br>
RoundTripPasses should always be called in DEBUG mode if the environment<br>
variable "LLD_RUN_ROUNDTRIP_TEST" is set.<br>
<br>
Flavors should not be able to override this behavior.<br>
<br>
Modified:<br>
     lld/trunk/include/lld/Core/<u></u>LinkingContext.h<br>
     lld/trunk/lib/Core/<u></u>LinkingContext.cpp<br>
<br>
Modified: lld/trunk/include/lld/Core/<u></u>LinkingContext.h<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/LinkingContext.h?rev=223073&r1=223072&r2=223073&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/include/lld/<u></u>Core/LinkingContext.h?rev=<u></u>223073&r1=223072&r2=223073&<u></u>view=diff</a><br>
<br>
==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/include/lld/Core/<u></u>LinkingContext.h (original)<br>
+++ lld/trunk/include/lld/Core/<u></u>LinkingContext.h Mon Dec  1 14:28:54 2014<br>
@@ -319,10 +319,6 @@ public:<br>
    virtual uint64_t getNextOrdinalAndIncrement() const { return<br>
_nextOrdinal++; }<br>
<br>
  #ifndef NDEBUG<br>
-  void setRunRoundTripPass(bool roundTripPass) {<br>
-    _runRoundTripPasses = roundTripPass;<br>
-  }<br>
-<br>
    bool runRoundTripPass() const { return _runRoundTripPasses; }<br>
  #endif<br>
<br>
<br>
Modified: lld/trunk/lib/Core/<u></u>LinkingContext.cpp<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/LinkingContext.cpp?rev=223073&r1=223072&r2=223073&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/lib/Core/<u></u>LinkingContext.cpp?rev=223073&<u></u>r1=223072&r2=223073&view=diff</a><br>
<br>
==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/lib/Core/<u></u>LinkingContext.cpp (original)<br>
+++ lld/trunk/lib/Core/<u></u>LinkingContext.cpp Mon Dec  1 14:28:54 2014<br>
@@ -32,7 +32,7 @@ LinkingContext::<u></u>LinkingContext()<br>
    llvm::Optional<std::string> env =<br>
        llvm::sys::Process::GetEnv("<u></u>LLD_RUN_ROUNDTRIP_TEST");<br>
    if (env.hasValue() && !env.getValue().empty())<br>
-    setRunRoundTripPass(true);<br>
+    _runRoundTripPasses = true;<br>
  }<br>
  #else<br>
  LinkingContext::<u></u>LinkingContext()<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote></blockquote>
<br>
<br></div></div><span class="HOEnZb"><font color="#888888">
-- <br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation<br>
<br>
</font></span></blockquote></div><br></div>