[lld] r222777 - [PECOFF] Ignore /maxilkfile option.

[Sean Silva]

/maxilkfile or /MAXILKFILE or /maxilksize ? The commit message talks about
the first two, but the code change only talks about the 3rd.

On Tue, Nov 25, 2014 at 11:51 AM, Rui Ueyama <ruiu at google.com> wrote:

> Author: ruiu
> Date: Tue Nov 25 13:51:28 2014
> New Revision: 222777
>
> URL: http://llvm.org/viewvc/llvm-project?rev=222777&view=rev
> Log:
> [PECOFF] Ignore /maxilkfile option.
>
> .ilk file is a file for incremental linking. We don't create nor use
> that file.
>
> /MAXILKFILE is an undocumented option to specify the maximum size
> of the .ilk file, IIUC. We should just ignore the option.
>
> Modified:
>     lld/trunk/lib/Driver/WinLinkOptions.td
>     lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp
>
> Modified: lld/trunk/lib/Driver/WinLinkOptions.td
> URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/WinLinkOptions.td?rev=222777&r1=222776&r2=222777&view=diff
>
> ==============================================================================
> --- lld/trunk/lib/Driver/WinLinkOptions.td (original)
> +++ lld/trunk/lib/Driver/WinLinkOptions.td Tue Nov 25 13:51:28 2014
> @@ -111,6 +111,7 @@ def delay : QF<"delay">;
>  def errorreport : QF<"errorreport">;
>  def idlout : QF<"idlout">;
>  def ignore : QF<"ignore">;
> +def maxilksize : QF<"maxilksize">;
>  def pdbaltpath : QF<"pdbaltpath">;
>  def tlbid : QF<"tlbid">;
>  def tlbout : QF<"tlbout">;
>
> Modified: lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp?rev=222777&r1=222776&r2=222777&view=diff
>
> ==============================================================================
> --- lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp (original)
> +++ lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp Tue Nov 25
> 13:51:28 2014
> @@ -702,7 +702,8 @@ TEST_F(WinLinkParserTest, Ignore) {
>                      "/verbose:icf", "/wx", "/wx:no", "/tlbid:1",
>                      "/tlbout:foo", "/idlout:foo", "/ignore:4000",
>                      "/ignoreidl", "/implib:foo", "/safeseh",
> -                    "/safeseh:no", "/functionpadmin", "a.obj", nullptr));
> +                    "/safeseh:no", "/functionpadmin", "/maxilksize:1024",
> +                    "a.obj", nullptr));
>    EXPECT_EQ("", errorMessage());
>    EXPECT_EQ(3, inputFileCount());
>    EXPECT_EQ("a.obj", inputFile(0));
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141125/0b192a76/attachment.html>