<div dir="ltr"><span style="font-family:arial,sans-serif;font-size:13px">/maxilkfile or </span><span style="font-family:arial,sans-serif;font-size:13px">/MAXILKFILE or </span><span style="font-family:arial,sans-serif;font-size:13px">/maxilksize ? The commit message talks about the first two, but the code change only talks about the 3rd.</span><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 25, 2014 at 11:51 AM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Tue Nov 25 13:51:28 2014<br>
New Revision: 222777<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=222777&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=222777&view=rev</a><br>
Log:<br>
[PECOFF] Ignore /maxilkfile option.<br>
<br>
.ilk file is a file for incremental linking. We don't create nor use<br>
that file.<br>
<br>
/MAXILKFILE is an undocumented option to specify the maximum size<br>
of the .ilk file, IIUC. We should just ignore the option.<br>
<br>
Modified:<br>
    lld/trunk/lib/Driver/WinLinkOptions.td<br>
    lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp<br>
<br>
Modified: lld/trunk/lib/Driver/WinLinkOptions.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/WinLinkOptions.td?rev=222777&r1=222776&r2=222777&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/WinLinkOptions.td?rev=222777&r1=222776&r2=222777&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/Driver/WinLinkOptions.td (original)<br>
+++ lld/trunk/lib/Driver/WinLinkOptions.td Tue Nov 25 13:51:28 2014<br>
@@ -111,6 +111,7 @@ def delay : QF<"delay">;<br>
 def errorreport : QF<"errorreport">;<br>
 def idlout : QF<"idlout">;<br>
 def ignore : QF<"ignore">;<br>
+def maxilksize : QF<"maxilksize">;<br>
 def pdbaltpath : QF<"pdbaltpath">;<br>
 def tlbid : QF<"tlbid">;<br>
 def tlbout : QF<"tlbout">;<br>
<br>
Modified: lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp?rev=222777&r1=222776&r2=222777&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp?rev=222777&r1=222776&r2=222777&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp (original)<br>
+++ lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp Tue Nov 25 13:51:28 2014<br>
@@ -702,7 +702,8 @@ TEST_F(WinLinkParserTest, Ignore) {<br>
                     "/verbose:icf", "/wx", "/wx:no", "/tlbid:1",<br>
                     "/tlbout:foo", "/idlout:foo", "/ignore:4000",<br>
                     "/ignoreidl", "/implib:foo", "/safeseh",<br>
-                    "/safeseh:no", "/functionpadmin", "a.obj", nullptr));<br>
+                    "/safeseh:no", "/functionpadmin", "/maxilksize:1024",<br>
+                    "a.obj", nullptr));<br>
   EXPECT_EQ("", errorMessage());<br>
   EXPECT_EQ(3, inputFileCount());<br>
   EXPECT_EQ("a.obj", inputFile(0));<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>