[PATCH] Add VSX loads/stores to fastisel for PPC target
Bill Schmidt
wschmidt at linux.vnet.ibm.com
Fri Nov 14 13:40:10 PST 2014
Looks pretty good -- just a couple of inline comments.
================
Comment at: /home/seurer/llvm/llvm-oneoff/lib/Target/PowerPC/PPCFastISel.cpp:145
@@ -142,1 +144,3 @@
+ (MRI.getRegClass(Register)->getID() == PPC::VSFRCRegClassID));
+ }
bool PPCEmitCmp(const Value *Src1Value, const Value *Src2Value,
----------------
I'd like to see this named isVSFRCRegister or the like. The VSFRC class comprises only the most-significant-half of each of the VSX registers (the VSRs), so I feel the name is misleading.
================
Comment at: /home/seurer/llvm/llvm-oneoff/lib/Target/PowerPC/PPCFastISel.cpp:494
@@ +493,3 @@
+ UseOffset = false;
+ assert(Addr.Base.Reg == 0 && "a non-zero base register was unexpectedly encountered");
+ }
----------------
echristo wrote:
> Hmm.. explain the assert here?
Yeah, I don't get this either.
http://reviews.llvm.org/D6274
More information about the llvm-commits
mailing list