[PATCH] Add VSX loads/stores to fastisel for PPC target

Eric Christopher echristo at gmail.com
Fri Nov 14 13:11:55 PST 2014


Few nits:

Clang-format? :)

Periods at the end of sentences.

Couple of inline comments.

Thanks!

================
Comment at: /home/seurer/llvm/llvm-oneoff/lib/Target/PowerPC/PPCFastISel.cpp:143
@@ +142,3 @@
+    bool isVSXRegister(unsigned Register) const {
+		   return ((Register != 0) && 
+             (MRI.getRegClass(Register)->getID() == PPC::VSFRCRegClassID));
----------------
I'd prefer to pull the Register != 0 out of this so that we can keep the general pattern of checking it. Thoughts?

================
Comment at: /home/seurer/llvm/llvm-oneoff/lib/Target/PowerPC/PPCFastISel.cpp:494
@@ +493,3 @@
+    UseOffset = false;
+    assert(Addr.Base.Reg == 0 && "a non-zero base register was unexpectedly encountered");
+  }
----------------
Hmm.. explain the assert here?

http://reviews.llvm.org/D6274






More information about the llvm-commits mailing list