[lld] r221552 - [mach-o] Fix MachOFileNode to own archives same as ELFFileNode

[Nick Kledzik]

On Nov 11, 2014, at 3:00 PM, David Blaikie <dblaikie at gmail.com> wrote:

> 
> 
> On Fri, Nov 7, 2014 at 2:00 PM, Nick Kledzik <kledzik at apple.com> wrote:
> Author: kledzik
> Date: Fri Nov  7 16:00:23 2014
> New Revision: 221552
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=221552&view=rev
> Log:
> [mach-o] Fix MachOFileNode to own archives same as ELFFileNode
> 
> My previous fix to have FileArchive own the member MemoryBuffers was not a
> complete solution for darwin because nothing owned the FileArchive object.
> Fixed MachOFileNode to be like ELFFileNode and have the graph node own the
> archive object.
> 
> Any test coverage for this/the previous change?
Yes.  I discovered the issue implementing the -order_file option.  The test added for order file uncovered the archive reader bug when running with guard-malloc.  I checked in the fix with a independently because it had nothing to do with the order file patch.  The order file pass is the only thing that tries to access that dangling reference.  

-Nick

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141111/17e5d64a/attachment.html>