<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Nov 11, 2014, at 3:00 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><br class="Apple-interchange-newline"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Fri, Nov 7, 2014 at 2:00 PM, Nick Kledzik<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:kledzik@apple.com" target="_blank">kledzik@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">Author: kledzik<br>Date: Fri Nov 7 16:00:23 2014<br>New Revision: 221552<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=221552&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=221552&view=rev</a><br>Log:<br>[mach-o] Fix MachOFileNode to own archives same as ELFFileNode<br><br>My previous fix to have FileArchive own the member MemoryBuffers was not a<br>complete solution for darwin because nothing owned the FileArchive object.<br>Fixed MachOFileNode to be like ELFFileNode and have the graph node own the<br>archive object.<br></blockquote><div><br></div><div>Any test coverage for this/the previous change?</div></div></blockquote>Yes. I discovered the issue implementing the -order_file option. The test added for order file uncovered the archive reader bug when running with guard-malloc. I checked in the fix with a independently because it had nothing to do with the order file patch. The order file pass is the only thing that tries to access that dangling reference. </div><div><br></div><div>-Nick</div><div><br></div></body></html>