[PATCH] Add process name to Asan logfile name and report message

Yury Gribov tetra2005 at gmail.com
Thu Nov 6 13:23:06 PST 2014


Perhaps it's time to ask for a commit access...

================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:324
@@ +323,3 @@
+  buf[0] = 0;
+  return 1;
+}
----------------
samsonov wrote:
> Shouldn't you return 0 in this case? (if we decide to keep "uptr" as return value of ReadBinaryName, we never use it anywhere)
Looks like you are right, readlink does not include the terminating 0 into the return value. Not sure about FreeBSD though.

http://reviews.llvm.org/D5724






More information about the llvm-commits mailing list