[PATCH] Add process name to Asan logfile name and report message

Alexey Samsonov vonosmas at gmail.com
Thu Nov 6 11:06:19 PST 2014


LGTM with one last nit. Feel free to commit after fixing it.

================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:324
@@ +323,3 @@
+  buf[0] = 0;
+  return 1;
+}
----------------
Shouldn't you return 0 in this case? (if we decide to keep "uptr" as return value of ReadBinaryName, we never use it anywhere)

================
Comment at: lib/sanitizer_common/sanitizer_win.cc:534
@@ +533,3 @@
+  buf[0] = 0;
+  return 1;
+}
----------------
ditto

http://reviews.llvm.org/D5724






More information about the llvm-commits mailing list