[PATCH] Add missing tests for build attribute encodings in object files.
Charlie Turner
charlie.turner at arm.com
Mon Nov 3 09:34:11 PST 2014
`test/MC/ARM/directive-eabi_attribute.s` was missing several tests of object file encodings relative to the existing tests for assembly file encodings. This commit adds the missing tests.
There is a small wrinkle adding object file tests for the following pair of assembly file tests,
```
.eabi_attribute Tag_compatibility, 1
@ CHECK: .eabi_attribute 32, 1
.eabi_attribute Tag_compatibility, 1, "aeabi"
@ CHECK: .eabi_attribute 32, 1, "aeabi"
```
because the object file encoder removes duplicate build attrs (delete all but the first occurrence AFAICT), whereas the assembly encoder does allow duplicate attrs. The object file test I used for the second of the above build attributes does cover both code paths, so it tests the same code as the pair of tests above.
http://reviews.llvm.org/D6093
Files:
test/MC/ARM/directive-eabi_attribute.s
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6093.15717.patch
Type: text/x-patch
Size: 7402 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141103/4d520143/attachment.bin>
More information about the llvm-commits
mailing list