[lld] r221165 - Fix warnings about missing override.
Rafael Espindola
rafael.espindola at gmail.com
Mon Nov 3 09:14:46 PST 2014
Author: rafael
Date: Mon Nov 3 11:14:46 2014
New Revision: 221165
URL: http://llvm.org/viewvc/llvm-project?rev=221165&view=rev
Log:
Fix warnings about missing override.
Modified:
lld/trunk/lib/ReaderWriter/ELF/Atoms.h
lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h
lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h
lld/trunk/lib/ReaderWriter/MachO/ArchHandler_arm64.cpp
lld/trunk/lib/ReaderWriter/MachO/ArchHandler_x86_64.cpp
lld/trunk/lib/ReaderWriter/MachO/File.h
lld/trunk/lib/ReaderWriter/PECOFF/Atoms.h
Modified: lld/trunk/lib/ReaderWriter/ELF/Atoms.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Atoms.h?rev=221165&r1=221164&r2=221165&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Atoms.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Atoms.h Mon Nov 3 11:14:46 2014
@@ -733,8 +733,6 @@ public:
ContentPermissions permissions() const override { return permRW_; }
- virtual ArrayRef<uint8_t> rawContent() const = 0;
-
Alignment alignment() const override {
// The alignment should be 8 byte aligned
return Alignment(3);
@@ -767,8 +765,6 @@ public:
ContentPermissions permissions() const override { return permR_X; }
- virtual ArrayRef<uint8_t> rawContent() const = 0;
-
Alignment alignment() const override {
return Alignment(4); // 16
}
@@ -861,8 +857,6 @@ public:
ContentPermissions permissions() const override { return permRW_; }
- virtual ArrayRef<uint8_t> rawContent() const = 0;
-
Alignment alignment() const override { return size(); }
#ifndef NDEBUG
Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h?rev=221165&r1=221164&r2=221165&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h Mon Nov 3 11:14:46 2014
@@ -38,9 +38,10 @@ protected:
return std::error_code();
}
- LLD_UNIQUE_BUMP_PTR(DynamicTable<ELFT>) createDynamicTable();
+ LLD_UNIQUE_BUMP_PTR(DynamicTable<ELFT>) createDynamicTable() override;
- LLD_UNIQUE_BUMP_PTR(DynamicSymbolTable<ELFT>) createDynamicSymbolTable();
+ LLD_UNIQUE_BUMP_PTR(DynamicSymbolTable<ELFT>)
+ createDynamicSymbolTable() override;
private:
MipsELFWriter<ELFT> _writeHelper;
Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h?rev=221165&r1=221164&r2=221165&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h Mon Nov 3 11:14:46 2014
@@ -38,9 +38,10 @@ protected:
return std::error_code();
}
- LLD_UNIQUE_BUMP_PTR(DynamicTable<ELFT>) createDynamicTable();
+ LLD_UNIQUE_BUMP_PTR(DynamicTable<ELFT>) createDynamicTable() override;
- LLD_UNIQUE_BUMP_PTR(DynamicSymbolTable<ELFT>) createDynamicSymbolTable();
+ LLD_UNIQUE_BUMP_PTR(DynamicSymbolTable<ELFT>)
+ createDynamicSymbolTable() override;
private:
MipsELFWriter<ELFT> _writeHelper;
Modified: lld/trunk/lib/ReaderWriter/MachO/ArchHandler_arm64.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/ArchHandler_arm64.cpp?rev=221165&r1=221164&r2=221165&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/MachO/ArchHandler_arm64.cpp (original)
+++ lld/trunk/lib/ReaderWriter/MachO/ArchHandler_arm64.cpp Mon Nov 3 11:14:46 2014
@@ -135,7 +135,7 @@ public:
const lld::Atom **target,
Reference::Addend *addend) override;
- virtual bool needsLocalSymbolInRelocatableFile(const DefinedAtom *atom) {
+ bool needsLocalSymbolInRelocatableFile(const DefinedAtom *atom) override {
return (atom->contentType() == DefinedAtom::typeCString);
}
Modified: lld/trunk/lib/ReaderWriter/MachO/ArchHandler_x86_64.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/ArchHandler_x86_64.cpp?rev=221165&r1=221164&r2=221165&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/MachO/ArchHandler_x86_64.cpp (original)
+++ lld/trunk/lib/ReaderWriter/MachO/ArchHandler_x86_64.cpp Mon Nov 3 11:14:46 2014
@@ -137,7 +137,7 @@ public:
const lld::Atom **target,
Reference::Addend *addend) override;
- virtual bool needsLocalSymbolInRelocatableFile(const DefinedAtom *atom) {
+ bool needsLocalSymbolInRelocatableFile(const DefinedAtom *atom) override {
return (atom->contentType() == DefinedAtom::typeCString);
}
Modified: lld/trunk/lib/ReaderWriter/MachO/File.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/File.h?rev=221165&r1=221164&r2=221165&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/MachO/File.h (original)
+++ lld/trunk/lib/ReaderWriter/MachO/File.h Mon Nov 3 11:14:46 2014
@@ -192,7 +192,8 @@ public:
: SharedLibraryFile(path), _installName(installName) {
}
- virtual const SharedLibraryAtom *exports(StringRef name, bool isData) const {
+ const SharedLibraryAtom *exports(StringRef name,
+ bool isData) const override {
// Pass down _installName and _allocator so that if this requested symbol
// is re-exported through this dylib, the SharedLibraryAtom's loadName()
// is this dylib installName and not the implementation dylib's.
Modified: lld/trunk/lib/ReaderWriter/PECOFF/Atoms.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/Atoms.h?rev=221165&r1=221164&r2=221165&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/PECOFF/Atoms.h (original)
+++ lld/trunk/lib/ReaderWriter/PECOFF/Atoms.h Mon Nov 3 11:14:46 2014
@@ -98,7 +98,6 @@ public:
Interposable interposable() const override { return interposeNo; }
Merge merge() const override { return mergeNo; }
Alignment alignment() const override { return Alignment(0); }
- SectionChoice sectionChoice() const = 0;
StringRef customSectionName() const override { return ""; }
SectionPosition sectionPosition() const override {
return sectionPositionAny;
More information about the llvm-commits
mailing list