[compiler-rt] r220991 - [asan] increase the initial buffer size in caller-callee dumper

[Kostya Serebryany]

On Fri, Oct 31, 2014 at 1:16 PM, Justin Bogner <mail at justinbogner.com>
wrote:

> Kostya Serebryany <kcc at google.com> writes:
> > Author: kcc
> > Date: Fri Oct 31 14:49:46 2014
> > New Revision: 220991
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=220991&view=rev
> > Log:
> > [asan] increase the initial buffer size in caller-callee dumper
> >
> > Modified:
> >     compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc
> >
> > Modified:
> compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc
> > URL:
> >
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc?rev=220991&r1=220990&r2=220991&view=diff
> >
> ==============================================================================
> > --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc
> (original)
> > +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc
> Fri Oct 31 14:49:46 2014
> > @@ -325,7 +325,7 @@ void CoverageData::DumpCallerCalleePairs
> >    auto sym = Symbolizer::GetOrInit();
> >    if (!sym)
> >      return;
> > -  InternalScopedString out(4096 * 16);
> > +  InternalScopedString out(32 << 20);
>
> This seems like an odd way to write this number. Do the 32 or the 20
> here have some sort of meaning that makes this clearer than 1 << 25?
>

X << 20 is simply X Mb, but I agree this is still not necessary good way to
write 32Mb.


>
> >    uptr total = 0;
> >    for (uptr i = 0; i < max_idx; i++) {
> >      uptr *cc_cache = cc_array[i];
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141031/91d71703/attachment.html>