<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 31, 2014 at 1:16 PM, Justin Bogner <span dir="ltr"><<a href="mailto:mail@justinbogner.com" target="_blank">mail@justinbogner.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Kostya Serebryany <<a href="mailto:kcc@google.com">kcc@google.com</a>> writes:<br>
> Author: kcc<br>
> Date: Fri Oct 31 14:49:46 2014<br>
> New Revision: 220991<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=220991&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=220991&view=rev</a><br>
> Log:<br>
> [asan] increase the initial buffer size in caller-callee dumper<br>
><br>
> Modified:<br>
>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc<br>
><br>
> Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc<br>
> URL:<br>
> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc?rev=220991&r1=220990&r2=220991&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc?rev=220991&r1=220990&r2=220991&view=diff</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc (original)<br>
> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep.cc Fri Oct 31 14:49:46 2014<br>
> @@ -325,7 +325,7 @@ void CoverageData::DumpCallerCalleePairs<br>
>    auto sym = Symbolizer::GetOrInit();<br>
>    if (!sym)<br>
>      return;<br>
> -  InternalScopedString out(4096 * 16);<br>
> +  InternalScopedString out(32 << 20);<br>
<br>
</span>This seems like an odd way to write this number. Do the 32 or the 20<br>
here have some sort of meaning that makes this clearer than 1 << 25?<br></blockquote><div><br></div><div>X << 20 is simply X Mb, but I agree this is still not necessary good way to write 32Mb. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
>    uptr total = 0;<br>
>    for (uptr i = 0; i < max_idx; i++) {<br>
>      uptr *cc_cache = cc_array[i];<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>