[PATCH] [AArch64] CondOpt pass is missing FCMPSri and FCMPDri

Sergey Dmitrouk sdmitrouk at accesssoftek.com
Fri Oct 31 04:23:58 PDT 2014


Hi,

again my bad, sorry about that. Please see one inline comment.

Thanks for fixing this!

Regards,
Sergey

================
Comment at: lib/Target/AArch64/AArch64ConditionOptimizer.cpp:165
@@ +164,3 @@
+    case AArch64::FCMPDri:
+    case AArch64::FCMPSri:
+
----------------
I checked `FPComparison` multiclass from `AArch64InstrFormats.td` and it creates 4 forms of an instruction. I missed `ri` forms for both `FCMP` and `FCMPE`, which means that two more cases should be added here as well:
```
    case AArch64::FCMPEDri:
    case AArch64::FCMPESri:
```

http://reviews.llvm.org/D6047






More information about the llvm-commits mailing list