[PATCH] [AArch64] CondOpt pass is missing FCMPSri and FCMPDri

Z. Zheng zhaoshiz at codeaurora.org
Thu Oct 30 16:24:19 PDT 2014


Hi apazos, Jiangning, t.p.northover, sdmitrouk,

We need to bail out on FCMPSri and FCMPDri when searching backward for a CMP which defines the flags used by B.CC.

This patch fixes the following false positive case:

 cmp      w19, #0
 cinc     w0, w19, gt
 ...
 fcmp     d8, #0.0
 b.gt     .LBB0_5

http://reviews.llvm.org/D6047

Files:
  lib/Target/AArch64/AArch64ConditionOptimizer.cpp
  test/CodeGen/AArch64/combine-comparisons-by-cse.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6047.15592.patch
Type: text/x-patch
Size: 2878 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141030/93bc9649/attachment.bin>


More information about the llvm-commits mailing list