[PATCH] Add process name to Asan logfile name and report message

Yury Gribov tetra2005 at gmail.com
Tue Oct 21 01:13:42 PDT 2014


================
Comment at: lib/sanitizer_common/sanitizer_common.cc:272
@@ +271,3 @@
+  if (base1 || base2)
+    return (base1 > base2 ? base1 : base2) + 1;
+  return name;
----------------
eugenis wrote:
> There is Max() definition in sanitizer_common.
Ah, ok, I looked at min/max in tsan_defs.h and thought that it's ok to reinvent adhoc max.

================
Comment at: lib/sanitizer_common/sanitizer_common.h:181
@@ -180,1 +180,3 @@
 // OS
+uptr ReadBinaryName(/*out*/char *buf, uptr buf_len);
+const char *ReadBinaryName();
----------------
eugenis wrote:
> You've got 2 overloads of ReadBinayName that do very different things.
> Rename to GetBinaryName?
Good point.

http://reviews.llvm.org/D5724






More information about the llvm-commits mailing list