[PATCH] Add process name to Asan logfile name and report message
Evgeniy Stepanov
eugenis at google.com
Mon Oct 20 10:13:37 PDT 2014
LGTM
================
Comment at: lib/sanitizer_common/sanitizer_common.cc:272
@@ +271,3 @@
+ if (base1 || base2)
+ return (base1 > base2 ? base1 : base2) + 1;
+ return name;
----------------
There is Max() definition in sanitizer_common.
================
Comment at: lib/sanitizer_common/sanitizer_common.h:181
@@ -180,1 +180,3 @@
// OS
+uptr ReadBinaryName(/*out*/char *buf, uptr buf_len);
+const char *ReadBinaryName();
----------------
You've got 2 overloads of ReadBinayName that do very different things.
Rename to GetBinaryName?
http://reviews.llvm.org/D5724
More information about the llvm-commits
mailing list