[llvm] r219516 - Add couple of missing 'override' keyword. NFC.

David Blaikie dblaikie at gmail.com
Fri Oct 10 10:48:39 PDT 2014


On Fri, Oct 10, 2014 at 10:34 AM, Fariborz Jahanian <fjahanian at apple.com>
wrote:

> Author: fjahanian
> Date: Fri Oct 10 12:34:30 2014
> New Revision: 219516
>
> URL: http://llvm.org/viewvc/llvm-project?rev=219516&view=rev
> Log:
> Add couple of missing 'override' keyword. NFC.
>
>
> Modified:
>     llvm/trunk/include/llvm/CodeGen/PBQPRAConstraint.h
>     llvm/trunk/lib/DebugInfo/DWARFUnit.h
>
> Modified: llvm/trunk/include/llvm/CodeGen/PBQPRAConstraint.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/PBQPRAConstraint.h?rev=219516&r1=219515&r2=219516&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/CodeGen/PBQPRAConstraint.h (original)
> +++ llvm/trunk/include/llvm/CodeGen/PBQPRAConstraint.h Fri Oct 10 12:34:30
> 2014
> @@ -61,7 +61,7 @@ public:
>    }
>  private:
>    std::vector<std::unique_ptr<PBQPRAConstraint>> Constraints;
> -  virtual void anchor();
> +  virtual void anchor() override;
>

Generally we omit the 'virtual' when providing 'override' (since override
implies virtual).


>  };
>
>  }
>
> Modified: llvm/trunk/lib/DebugInfo/DWARFUnit.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFUnit.h?rev=219516&r1=219515&r2=219516&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/DebugInfo/DWARFUnit.h (original)
> +++ llvm/trunk/lib/DebugInfo/DWARFUnit.h Fri Oct 10 12:34:30 2014
> @@ -71,7 +71,7 @@ public:
>    typedef typename UnitVector::iterator iterator;
>    typedef llvm::iterator_range<typename UnitVector::iterator>
> iterator_range;
>
> -  UnitType *getUnitForOffset(uint32_t Offset) const {
> +  UnitType *getUnitForOffset(uint32_t Offset) const override {
>      auto *CU = std::upper_bound(this->begin(), this->end(), Offset,
>                                  UnitOffsetComparator());
>      if (CU != this->end())
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141010/4f083e07/attachment.html>


More information about the llvm-commits mailing list