<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 10, 2014 at 10:34 AM, Fariborz Jahanian <span dir="ltr"><<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: fjahanian<br>
Date: Fri Oct 10 12:34:30 2014<br>
New Revision: 219516<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=219516&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=219516&view=rev</a><br>
Log:<br>
Add couple of missing 'override' keyword. NFC.<br>
<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/CodeGen/PBQPRAConstraint.h<br>
    llvm/trunk/lib/DebugInfo/DWARFUnit.h<br>
<br>
Modified: llvm/trunk/include/llvm/CodeGen/PBQPRAConstraint.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/PBQPRAConstraint.h?rev=219516&r1=219515&r2=219516&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/PBQPRAConstraint.h?rev=219516&r1=219515&r2=219516&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/CodeGen/PBQPRAConstraint.h (original)<br>
+++ llvm/trunk/include/llvm/CodeGen/PBQPRAConstraint.h Fri Oct 10 12:34:30 2014<br>
@@ -61,7 +61,7 @@ public:<br>
   }<br>
 private:<br>
   std::vector<std::unique_ptr<PBQPRAConstraint>> Constraints;<br>
-  virtual void anchor();<br>
+  virtual void anchor() override;<br></blockquote><div><br></div><div>Generally we omit the 'virtual' when providing 'override' (since override implies virtual).</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 };<br>
<br>
 }<br>
<br>
Modified: llvm/trunk/lib/DebugInfo/DWARFUnit.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFUnit.h?rev=219516&r1=219515&r2=219516&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFUnit.h?rev=219516&r1=219515&r2=219516&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/DebugInfo/DWARFUnit.h (original)<br>
+++ llvm/trunk/lib/DebugInfo/DWARFUnit.h Fri Oct 10 12:34:30 2014<br>
@@ -71,7 +71,7 @@ public:<br>
   typedef typename UnitVector::iterator iterator;<br>
   typedef llvm::iterator_range<typename UnitVector::iterator> iterator_range;<br>
<br>
-  UnitType *getUnitForOffset(uint32_t Offset) const {<br>
+  UnitType *getUnitForOffset(uint32_t Offset) const override {<br>
     auto *CU = std::upper_bound(this->begin(), this->end(), Offset,<br>
                                 UnitOffsetComparator());<br>
     if (CU != this->end())<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>