[PATCH] Update dwarf::ApplePropertyAttributes enum to meaningful values.

David Blaikie dblaikie at gmail.com
Tue Oct 7 12:00:03 PDT 2014


I'll leave this to Adrian to sign off on, since it's out of my depth in ObjC land, but I can confirm that this enum now matches the other one.

================
Comment at: include/llvm/Support/Dwarf.h:784
@@ -783,1 +783,3 @@
+/// Contstants for the DW_APPLE_PROPERTY_attributes attribute.
+/// Keep this list in sync with clang's DeclSpec.h ObjCPropertyAttributeKind.
 enum ApplePropertyAttributes {
----------------
Crazy idea: Could we do this the other way around, and remove ObjCPropertyAttributeKind in favor of using this enum directly?

Probably not, but figured I'd mention it.

http://reviews.llvm.org/D5653






More information about the llvm-commits mailing list