[PATCH] Update dwarf::ApplePropertyAttributes enum to meaningful values.

Frederic Riss friss at apple.com
Tue Oct 7 11:21:31 PDT 2014


Hi echristo, dblaikie, aprantl,

We currently emit an DW_AT_APPLE_property_attribute with a value that is a
bitfield describing the various attributes applied to an ObjectiveC property.
While trying to add testing to one of my dwarfdump patches that would pretty
print that, I realized this information looks totally broken and has maybe
never been correct.

As with every DWARF info, we have some enum in Dwarf.h that describes this
attribute (enum ApplePropertyAttributes). It seems however that the attribute
value is set from another definition of these flags in Sema/DeclSpec.h (enum
ObjCPropertyAttributeKind). And these 2 enums aren't in sync.

This patch updates the Dwarf.h values to the ones we are (and have been for
a very long time) emitting. We change some publicly (and even documented
in SourceLevelDebugging.rst) values, but I doubt this could be an issue as
the information has been wrong for so long...

http://reviews.llvm.org/D5653

Files:
  docs/SourceLevelDebugging.rst
  include/llvm/Support/Dwarf.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5653.14520.patch
Type: text/x-patch
Size: 3411 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141007/7bbb147b/attachment.bin>


More information about the llvm-commits mailing list