[compiler-rt] r218545 - Effectively revert r217284 on Darwin due to issues with -gmlt there

[David Blaikie]

On Fri, Sep 26, 2014 at 2:58 PM, Alexey Samsonov <vonosmas at gmail.com> wrote:

> Author: samsonov
> Date: Fri Sep 26 16:58:33 2014
> New Revision: 218545
>
> URL: http://llvm.org/viewvc/llvm-project?rev=218545&view=rev
> Log:
> Effectively revert r217284 on Darwin due to issues with -gmlt there
>

Not sure if this is the right direction - but maybe I'm confused about what
was discussed in the other thread.

I assume Apple uses/cares about -gmlt working on their platform and it
currently doesn't. (I could be wrong though - maybe they don't care about
-gmlt) This change would just paper over that.

But if -gmlt's behavior on Apple isn't important to anyone, I'm fine with
this - keeps the code simpler on my side of things.


>
> Modified:
>     compiler-rt/trunk/test/lit.common.cfg
>
> Modified: compiler-rt/trunk/test/lit.common.cfg
> URL:
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/lit.common.cfg?rev=218545&r1=218544&r2=218545&view=diff
>
> ==============================================================================
> --- compiler-rt/trunk/test/lit.common.cfg (original)
> +++ compiler-rt/trunk/test/lit.common.cfg Fri Sep 26 16:58:33 2014
> @@ -25,9 +25,12 @@ if compiler_id == "Clang":
>      config.cxx_mode_flags = ["--driver-mode=g++"]
>    else:
>      config.cxx_mode_flags = []
> -  # We assume that sanitizers should provide good enough error
> -  # reports and stack traces even with minimal debug info.
> -  config.debug_info_flags = ["-gline-tables-only"]
> +  if config.host_os not in ['Darwin']:
> +    # We assume that sanitizers should provide good enough error
> +    # reports and stack traces even with minimal debug info.
> +    config.debug_info_flags = ["-gline-tables-only"]
> +  else:
> +    config.debug_info_flags = ["-g"]
>  elif compiler_id == 'GNU':
>    config.cxx_mode_flags = ["-x c++"]
>    config.debug_info_flags = ["-g"]
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140926/7c1e935c/attachment.html>