<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 26, 2014 at 2:58 PM, Alexey Samsonov <span dir="ltr"><<a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: samsonov<br>
Date: Fri Sep 26 16:58:33 2014<br>
New Revision: 218545<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=218545&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=218545&view=rev</a><br>
Log:<br>
Effectively revert r217284 on Darwin due to issues with -gmlt there<br></blockquote><div><br></div><div>Not sure if this is the right direction - but maybe I'm confused about what was discussed in the other thread.<br><br>I assume Apple uses/cares about -gmlt working on their platform and it currently doesn't. (I could be wrong though - maybe they don't care about -gmlt) This change would just paper over that.<br><br>But if -gmlt's behavior on Apple isn't important to anyone, I'm fine with this - keeps the code simpler on my side of things.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    compiler-rt/trunk/test/lit.common.cfg<br>
<br>
Modified: compiler-rt/trunk/test/lit.common.cfg<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/lit.common.cfg?rev=218545&r1=218544&r2=218545&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/lit.common.cfg?rev=218545&r1=218544&r2=218545&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/lit.common.cfg (original)<br>
+++ compiler-rt/trunk/test/lit.common.cfg Fri Sep 26 16:58:33 2014<br>
@@ -25,9 +25,12 @@ if compiler_id == "Clang":<br>
     config.cxx_mode_flags = ["--driver-mode=g++"]<br>
   else:<br>
     config.cxx_mode_flags = []<br>
-  # We assume that sanitizers should provide good enough error<br>
-  # reports and stack traces even with minimal debug info.<br>
-  config.debug_info_flags = ["-gline-tables-only"]<br>
+  if config.host_os not in ['Darwin']:<br>
+    # We assume that sanitizers should provide good enough error<br>
+    # reports and stack traces even with minimal debug info.<br>
+    config.debug_info_flags = ["-gline-tables-only"]<br>
+  else:<br>
+    config.debug_info_flags = ["-g"]<br>
 elif compiler_id == 'GNU':<br>
   config.cxx_mode_flags = ["-x c++"]<br>
   config.debug_info_flags = ["-g"]<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>