[PATCH] [PATCH] Test case and FastISel fixes with FeatureVSX enabled

Eric Christopher echristo at gmail.com
Fri Sep 19 09:52:23 PDT 2014


On Fri, Sep 19, 2014 at 5:17 AM, hfinkel at anl.gov <hfinkel at anl.gov> wrote:
> Thanks for working on this!
>
> Regarding approach, instead of disabling parts of FastISel when VSX is enabled, why don't we disable VSX when FastISel would be used? For example, what if in PPCSubtarget::initSubtargetFeatures we added something like this after the call to ParseSubtargetFeatures:
>
>   if (OptLevel == CodeGenOpt::None) or even better if possible (TM.Options.EnableFastISel)
>     HasVSX = false;
>
> (we already do something similar for little-Endian mode currently). Then we just need to add an assert in the FastISel implementation that VSX is not enabled.
>

What about builtins? If you don't enable the subtarget feature you
won't be able to select any code that uses VSX in fast isel mode -
even if you could with the selection dag.




More information about the llvm-commits mailing list