[PATCH] [PATCH] Test case and FastISel fixes with FeatureVSX enabled
hfinkel at anl.gov
hfinkel at anl.gov
Fri Sep 19 05:17:50 PDT 2014
Thanks for working on this!
Regarding approach, instead of disabling parts of FastISel when VSX is enabled, why don't we disable VSX when FastISel would be used? For example, what if in PPCSubtarget::initSubtargetFeatures we added something like this after the call to ParseSubtargetFeatures:
if (OptLevel == CodeGenOpt::None) or even better if possible (TM.Options.EnableFastISel)
HasVSX = false;
(we already do something similar for little-Endian mode currently). Then we just need to add an assert in the FastISel implementation that VSX is not enabled.
As a general note, please upload full-context diffs in the future (see http://llvm.org/docs/Phabricator.html for instructions).
http://reviews.llvm.org/D5362
More information about the llvm-commits
mailing list