[PATCH] Rename getNoopForMachoTarget to getNoop

[Jim Grosbach]

> On Sep 15, 2014, at 12:50 PM, Brad Smith <brad at comstyle.com> wrote:
> 
> On 15/09/14 2:45 PM, Rafael Espíndola wrote:
>> On 15 September 2014 14:39, Brad Smith <brad at comstyle.com> wrote:
>>> On 15/09/14 1:19 PM, Rafael Espíndola wrote:
>>>> 
>>>> I think this is wrong. We should just produce empty functions for
>>>> non-MachO.
>>> 
>>> 
>>> Then send a diff to do it.
>> 
>> Fixed. In the future, do *not* commit patches without approval.
> 
> It was approved.

Where? I just re-read the thread and don’t see it. Is there somewhere else I should be looking?

> 
>> "This is not the correct way to fix it" is a pretty standard code
>> review. Please get used to it.
> 
> 
> -- 
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits