[PATCH] Rename getNoopForMachoTarget to getNoop

Brad Smith brad at comstyle.com
Mon Sep 15 12:50:09 PDT 2014


On 15/09/14 2:45 PM, Rafael EspĂ­ndola wrote:
> On 15 September 2014 14:39, Brad Smith <brad at comstyle.com> wrote:
>> On 15/09/14 1:19 PM, Rafael EspĂ­ndola wrote:
>>>
>>> I think this is wrong. We should just produce empty functions for
>>> non-MachO.
>>
>>
>> Then send a diff to do it.
>
> Fixed. In the future, do *not* commit patches without approval.

It was approved.

> "This is not the correct way to fix it" is a pretty standard code
> review. Please get used to it.


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.





More information about the llvm-commits mailing list