[PATCH] Fix bug in CallInst::CreateFree(Value* Source, BasicBlock *InsertAtEnd)

[Johannes Doerfert]

On 09/12, Rafael Espíndola wrote:
> The comment says
> 
> /// Note: This function does not add the call to the basic block, that is the
> /// responsibility of the caller
> 
> So this looks like a peculiar but correct implementation. I guess we
> can change it, but we should check the callers and update the comment.
It was also reported in http://llvm.org/bugs/show_bug.cgi?id=18623.
If you change the behaviour we can close the bug.

> On 25 April 2014 08:04, Stephan Falke <falke at iti.uka.de> wrote:
> > Hi,
> >
> > I noticed a problem with CallInst::CreateFree(Value* Source, BasicBlock
> > *InsertAtEnd).  The CallInst that is created is not actually inserted into
> > the specified BasicBlock.  This problem seems to have been introduced in
> > r84987, when CallInst::CreateFree was initially introduced.  The attached
> > patch should fix this problem.
> >
> > Cheers,
> > Stephan
> >
> > PS: I don't have commit access to the repository.
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-- 

Johannes Doerfert
Researcher / PhD Student

Compiler Design Lab (Prof. Hack)
Saarland University, Computer Science
Building E1.3, Room 4.26

Tel. +49 (0)681 302-57521 : doerfert at cs.uni-saarland.de
Fax. +49 (0)681 302-3065  : http://www.cdl.uni-saarland.de/people/doerfert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140913/9e898c39/attachment.sig>