[PATCH] Fix bug in CallInst::CreateFree(Value* Source, BasicBlock *InsertAtEnd)

[Rafael Espíndola]

The comment says

/// Note: This function does not add the call to the basic block, that is the
/// responsibility of the caller

So this looks like a peculiar but correct implementation. I guess we
can change it, but we should check the callers and update the comment.



On 25 April 2014 08:04, Stephan Falke <falke at iti.uka.de> wrote:
> Hi,
>
> I noticed a problem with CallInst::CreateFree(Value* Source, BasicBlock
> *InsertAtEnd).  The CallInst that is created is not actually inserted into
> the specified BasicBlock.  This problem seems to have been introduced in
> r84987, when CallInst::CreateFree was initially introduced.  The attached
> patch should fix this problem.
>
> Cheers,
> Stephan
>
> PS: I don't have commit access to the repository.
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>