[rfc][gold plugin] Fix pr19901

[Nick Lewycky]

t1.patch:

diff --git a/include/llvm/Transforms/IPO/PassManagerBuilder.h
b/include/llvm/Transforms/IPO/PassManagerBuilder.h
index 71b2426..2f5fb05 100644
--- a/include/llvm/Transforms/IPO/PassManagerBuilder.h
+++ b/include/llvm/Transforms/IPO/PassManagerBuilder.h
@@ -20,6 +20,7 @@
 namespace llvm {
 class TargetLibraryInfo;
 class Pass;
+class TargetMachine;

Your insertion is correct, but please sort. :)

+  // Start off with a verification pass.
+  PM.add(createVerifierPass());
+  PM.add(createDebugInfoVerifierPass());

What, unconditionally? So I'm pretty sure PMB used to have an option to
control whether verifiers were inserted, now I don't see it (but it still
#include's the Verifier header). What does clang -cc1's -disable-verifier
flag actually control?

Anyways, unconditionally running the verifier is wrong, even if that's what
the code is currently doing. None of that. Conditionally running it or not
running it are fine.

t2.patch LGTM. I expect there may be some fallout since this is essentially
a rewrite, but it makes sense to land it and then try to find bugs.

Nick

On 20 August 2014 10:07, Rafael Espíndola <rafael.espindola at gmail.com>
wrote:

> Rebased again to build after the buffer ownership changes on trunk.
>
> On 19 August 2014 12:11, Rafael Espíndola <rafael.espindola at gmail.com>
> wrote:
> > Ping. Rebased patches attached.
> >
> >
> >
> > On 15 August 2014 16:35, Rafael Espíndola <rafael.espindola at gmail.com>
> wrote:
> >> For reference, here are the latest versions of the patches rebased
> >> against current trunk.
> >>
> >> Cheers,
> >> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140820/7e98c56b/attachment.html>