[llvm] r213974 - llvm-uselistorder: Fix up LINK_COMPONENTS.

[Duncan P. N. Exon Smith]

Okay, this makes sense to me!

> On 2014 Aug 3, at 15:02, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> 
> I introduced PRIVATE linkage in CMake's target_link_libraries for Win32.DLL.
> PRIVATE doesn't bring subsequent dependencies. For example,
> Core brings nothing with PRIVATE, although Core brings Support with
> PUBLIC|INTERFACE.
> 
> Now, LINK_COMPONENTS requires "libraries actually used directly" for
> each target.
> 
> I think it'd be better to keep dependencies. To brush up dependencies,
> we can just simply scan each object file, or inspect each source file.
> 
> 2014-08-04 4:21 GMT+09:00 Duncan P. N. Exon Smith <dexonsmith at apple.com>:
>> 
>> Thanks for fixing this up!
>> 
>> I'm not sure why it was necessary though: was it causing a build
>> failure, or was this just a style cleanup?  It looked to me like
>> IRReader pulled in AsmParser and BitReader, and from the other
>> Makefiles it looked like we used all lowercase there.