[llvm] r213974 - llvm-uselistorder: Fix up LINK_COMPONENTS.

[NAKAMURA Takumi]

I introduced PRIVATE linkage in CMake's target_link_libraries for Win32.DLL.
PRIVATE doesn't bring subsequent dependencies. For example,
Core brings nothing with PRIVATE, although Core brings Support with
PUBLIC|INTERFACE.

Now, LINK_COMPONENTS requires "libraries actually used directly" for
each target.

I think it'd be better to keep dependencies. To brush up dependencies,
we can just simply scan each object file, or inspect each source file.

2014-08-04 4:21 GMT+09:00 Duncan P. N. Exon Smith <dexonsmith at apple.com>:
>
>> On 2014 Jul 25, at 14:33, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>>
>> Author: chapuni
>> Date: Fri Jul 25 16:33:18 2014
>> New Revision: 213974
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=213974&view=rev
>> Log:
>> llvm-uselistorder: Fix up LINK_COMPONENTS.
>>
>> Modified:
>>    llvm/trunk/tools/llvm-uselistorder/CMakeLists.txt
>>    llvm/trunk/tools/llvm-uselistorder/Makefile
>>
>
> Thanks for fixing this up!
>
> I'm not sure why it was necessary though: was it causing a build
> failure, or was this just a style cleanup?  It looked to me like
> IRReader pulled in AsmParser and BitReader, and from the other
> Makefiles it looked like we used all lowercase there.
>
>> Modified: llvm/trunk/tools/llvm-uselistorder/CMakeLists.txt
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-uselistorder/CMakeLists.txt?rev=213974&r1=213973&r2=213974&view=diff
>> ==============================================================================
>> --- llvm/trunk/tools/llvm-uselistorder/CMakeLists.txt (original)
>> +++ llvm/trunk/tools/llvm-uselistorder/CMakeLists.txt Fri Jul 25 16:33:18 2014
>> @@ -1,7 +1,10 @@
>> set(LLVM_LINK_COMPONENTS
>> -  Support
>> -  IRReader
>> +  AsmParser
>> +  BitReader
>>   BitWriter
>> +  Core
>> +  IRReader
>> +  Support
>>   )
>>
>> add_llvm_tool(llvm-uselistorder
>>
>> Modified: llvm/trunk/tools/llvm-uselistorder/Makefile
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-uselistorder/Makefile?rev=213974&r1=213973&r2=213974&view=diff
>> ==============================================================================
>> --- llvm/trunk/tools/llvm-uselistorder/Makefile (original)
>> +++ llvm/trunk/tools/llvm-uselistorder/Makefile Fri Jul 25 16:33:18 2014
>> @@ -9,7 +9,7 @@
>>
>> LEVEL := ../..
>> TOOLNAME := llvm-uselistorder
>> -LINK_COMPONENTS := support irreader bitwriter
>> +LINK_COMPONENTS := AsmParser BitReader BitWriter Core IRReader Support
>>
>> # This tool has no plugins, optimize startup time.
>> TOOL_NO_EXPORTS := 1
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>