[PATCH] Make LNT compatible with PostgreSQL

[Chris Matthews]

LGTM.

> On Jul 31, 2014, at 4:34 AM, Yi Kong <kongy.dev at gmail.com> wrote:
> 
> I've updated the patch to handle failures, and expanded tests.
> 
> -Yi
> 
> On 28 July 2014 16:15, Yi Kong <kongy.dev at gmail.com> wrote:
>> Hi Chris,
>> 
>> Sorry for the delay, I've been occupied by some other work.
>> 
>> Can you try this test and see if it works on your Jenkins? I will
>> expand the test coverage if it proves to be working.
>> 
>> Cheers,
>> 
>> Yi
>> 
>> On 24 July 2014 00:29, Chris Matthews <chris.matthews at apple.com> wrote:
>>> The lit test suite supports a requires clause.  This allows you to do this
>>> 
>>> # REQUIRES: postgres
>>> 
>>> In a test, then that test is only run if a —param postgres=True is passed to the lit invocation.  This allows us to keep the tests disabled for all except people who want to run the extra postgres tests.
>>> 
>>> I have a Jenkins bot, which I could install postgres on, so we would have coverage on postgres there.
>>> 
>>> Would it be possible to start the lit script off with a psql command which drop/creates a database first?  so the database name and URL are known ahead of time.
>>> 
>>>> On Jul 23, 2014, at 7:41 AM, Yi Kong <kongy.dev at gmail.com> wrote:
>>>> 
>>>> On 21 July 2014 23:49, Chris Matthews <chris.matthews at apple.com> wrote:
>>>>> Okay. That is fine.  I think it is okay to tell people to start fresh if they are going to switch.
>>>>> 
>>>>> Go ahead and commit your patch to add the Postgres creation capability.
>>>>> 
>>>>> Can you add a little blurb to docs/tools.rst explaining how to create for Postgres.
>>>>> 
>>>>> Could you also add a Postgres requires directive to the LNT test suite (off by default),
>>>> 
>>>> I'm not sure what do you mean. Are you suggesting adding 'psycopg2' to
>>>> install_requires?
>>>> 
>>>>> and make a new test in lnttool to test this code path?
>>>> 
>>>> It's not easily testable as Postgres doesn't support in-memory scratch database.
>>>> 
>>>> Thanks for reviewing!
>>>> 
>>>> -Yi
>>> 
> <lnt_psql.diff>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140731/93e8ba08/attachment.html>