<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">LGTM.<div><br><div style=""><blockquote type="cite"><div>On Jul 31, 2014, at 4:34 AM, Yi Kong <<a href="mailto:kongy.dev@gmail.com">kongy.dev@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div><span style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">I've updated the patch to handle failures, and expanded tests.</span><br style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">-Yi</span><br style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">On 28 July 2014 16:15, Yi Kong <</span><a href="mailto:kongy.dev@gmail.com" style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">kongy.dev@gmail.com</a><span style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">> wrote:</span><br style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><blockquote type="cite" style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Hi Chris,<br><br>Sorry for the delay, I've been occupied by some other work.<br><br>Can you try this test and see if it works on your Jenkins? I will<br>expand the test coverage if it proves to be working.<br><br>Cheers,<br><br>Yi<br><br>On 24 July 2014 00:29, Chris Matthews <<a href="mailto:chris.matthews@apple.com">chris.matthews@apple.com</a>> wrote:<br><blockquote type="cite">The lit test suite supports a requires clause. This allows you to do this<br><br># REQUIRES: postgres<br><br>In a test, then that test is only run if a —param postgres=True is passed to the lit invocation. This allows us to keep the tests disabled for all except people who want to run the extra postgres tests.<br><br>I have a Jenkins bot, which I could install postgres on, so we would have coverage on postgres there.<br><br>Would it be possible to start the lit script off with a psql command which drop/creates a database first? so the database name and URL are known ahead of time.<br><br><blockquote type="cite">On Jul 23, 2014, at 7:41 AM, Yi Kong <<a href="mailto:kongy.dev@gmail.com">kongy.dev@gmail.com</a>> wrote:<br><br>On 21 July 2014 23:49, Chris Matthews <<a href="mailto:chris.matthews@apple.com">chris.matthews@apple.com</a>> wrote:<br><blockquote type="cite">Okay. That is fine. I think it is okay to tell people to start fresh if they are going to switch.<br><br>Go ahead and commit your patch to add the Postgres creation capability.<br><br>Can you add a little blurb to docs/tools.rst explaining how to create for Postgres.<br><br>Could you also add a Postgres requires directive to the LNT test suite (off by default),<br></blockquote><br>I'm not sure what do you mean. Are you suggesting adding 'psycopg2' to<br>install_requires?<br><br><blockquote type="cite">and make a new test in lnttool to test this code path?<br></blockquote><br>It's not easily testable as Postgres doesn't support in-memory scratch database.<br><br>Thanks for reviewing!<br><br>-Yi<br></blockquote><br></blockquote></blockquote><span><lnt_psql.diff></span></div></blockquote></div><br></div></body></html>