[PATCH] extracting swapStruct into include/llvm/Support/MachO.h (no functional change)
kledzik at apple.com
Thu Jul 17 11:28:06 PDT 2014
On Jul 17, 2014, at 9:54 AM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>> On 2014-Jul-09, at 03:19, Artyom Skrobov <Artyom.Skrobov at arm.com> wrote:
>> Thank you Duncan
>>>> While committing this, I realised that the instantiations of swapStruct() in
>>>> tools/lld/lib/ReaderWriter/MachO/MachONormalizedFileBinaryUtils.h are
>>>> identical to the private implementations in lib/Object/MachOObjectFile.cpp
>>>> Should perhaps these swapStruct()'s be extracted into
>>>> include/llvm/Support/MachO.h ?
>>>> Attaching the patch for review.
>>> Sorry, I've lost context on this -- can you re-attach the patch?
>> No problem -- attaching that patch again.
> This LGTM, but I'm not sure I'm the right one to review it.
> Nick, could you take a look at Artyom's patch (reattached here)? Is
> this direction okay?
Yes. The lld changes are all good to me.
You should ping Michael Spenser about the lib/Object//MachOObjectFile.cpp changes.
More information about the llvm-commits