[PATCH] extracting swapStruct into include/llvm/Support/MachO.h (no functional change)

Duncan P. N. Exon Smith dexonsmith at apple.com
Thu Jul 17 09:54:50 PDT 2014

> On 2014-Jul-09, at 03:19, Artyom Skrobov <Artyom.Skrobov at arm.com> wrote:
> Thank you Duncan
>>> While committing this, I realised that the instantiations of swapStruct()
> in
>>> tools/lld/lib/ReaderWriter/MachO/MachONormalizedFileBinaryUtils.h are
>>> identical to the private implementations in
> lib/Object/MachOObjectFile.cpp
>>> Should perhaps these swapStruct()'s be extracted into
>>> include/llvm/Support/MachO.h ?
>>> Attaching the patch for review.
>> Sorry, I've lost context on this -- can you re-attach the patch?
> No problem -- attaching that patch again.

This LGTM, but I'm not sure I'm the right one to review it.

Nick, could you take a look at Artyom's patch (reattached here)?  Is
this direction okay?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: SwapStruct.patch
Type: application/octet-stream
Size: 20361 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140717/f8a2a1b2/attachment.obj>

More information about the llvm-commits mailing list