[PATCH] Revert Thumb-2 conversion of ARM builtins.

Stephen Hines srhines at google.com
Thu Jul 17 01:12:47 PDT 2014


Many of the files in this change use computed jumps and it seems like there
were no tests checked in to verify the new Thumb-2 behavior. The original
change also claims that the "code remains compatible with older CPUs with
no adverse effects". I dispute that there are no adverse effects here,
since the Thumb-2 predicated instructions certainly have different
timings/behavior than their equivalent ARM counterparts.

Steve


On Thu, Jul 17, 2014 at 1:02 AM, Tim Northover <t.p.northover at gmail.com>
wrote:

> Hi Stephen,
>
>
> > The umodsi3 code computes jump targets based on ARM encodings (if CLZ is
> > present and IDIV is not present).
>
> Reverting everything seems a little extreme if only a few functions
> are computing jumps like this. Can't we be a bit more targeted?
>
> Cheers.
>
> Tim.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140717/eaf267a8/attachment.html>


More information about the llvm-commits mailing list