[PATCH] COFF: Minor fix to Section size calculation

Keno Fischer kfischer at college.harvard.edu
Mon Jun 30 16:01:54 PDT 2014


Ok, I will come up with a test case test.

================
Comment at: lib/Object/COFFObjectFile.cpp:835
@@ +834,3 @@
+  // than SizeOfRawData.
+  // Since for debug sections later on the actual data matters, we take
+  // the min of SizeOfRawData and VirtualSize which is the acutal size
----------------
Eric Christopher wrote:
> Instead of later on, how about a comment about "after linking"?
Hmm, I intended it to mean, "later when LLVM is looking at the debug info". I see that this wording might be confusing. Will reword.

http://reviews.llvm.org/D4087






More information about the llvm-commits mailing list