[PATCH] COFF: Minor fix to Section size calculation

Eric Christopher echristo at gmail.com
Mon Jun 30 15:56:21 PDT 2014


It is acceptable to put in a fully linked binary.

One more comment below.

Thanks!

================
Comment at: lib/Object/COFFObjectFile.cpp:835
@@ +834,3 @@
+  // than SizeOfRawData.
+  // Since for debug sections later on the actual data matters, we take
+  // the min of SizeOfRawData and VirtualSize which is the acutal size
----------------
Instead of later on, how about a comment about "after linking"?

http://reviews.llvm.org/D4087






More information about the llvm-commits mailing list