[polly] Add diagnostic remark for ReportVariantBasePtr

[Tobias Grosser]

On 26/06/2014 16:08, Andreas Simbuerger wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
>
> On 06/26/2014 04:00 PM, Tobias Grosser wrote:
>> On 26/06/2014 15:38, Andreas Simbuerger wrote:
>>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>>>
>>> At the moment the DebugLoc is derived from the BaseValue. I'm not
>>> 100% sure if the resulting DebugLoc corresponds to the A or the
>>> (A->b) BaseValue.
>>
>> Possibly A->b.
>
> Yep, I meant 100%-sure from the output of the DebugLoc ;-).
>
>>
>>> As far as I can tell, both would map to the same source location
>>> in the debug-metadata.
>>
>> The caret diagnostic points for me at the beginning of the line.
>> This is good. If we ever figure out how to get the precise column
>> location, that would be amazing.
>
> That's what I would love to have. But well, so far it should be
> helpful enough. ;-)

Its extremely useful already. No complains from my side. Just putting 
this on the 'nice-to-have-if-someone-has-an-idea-and-time' list.

>> Also, I figured that I need to add -polly-detect-track-failures to
>> get the missed optimizations output. As the possibly expensive
>> formatting is done afterwards, I wonder if it would make sense to
>> enable it by default?
>>
>
> You mean tracking failures? Sure why not, by default it's only
> tracking one error per region anyway. Shouldn't be too bad.

You can try to enable it one of the following days, when no other polly
changes go in. That should allow us to see any unexpected problems on
llvm.org/perf.

Tobias